Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action loop and callback mapping tests #93

Merged
merged 19 commits into from
Oct 10, 2023

Conversation

petar-qb
Copy link
Contributor

@petar-qb petar-qb commented Oct 4, 2023

Description

  • Fixed export_data targets issue - Any False object is treated as all targets set.
  • Unit tests for fixed export_data fixed bug.
  • Unit tests for the Action loop util functions.
  • Unit tests for the callback mapping util functions.
  • The code coverage is increased (from 87% -> 93%).

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added the PR number to the change description in the changelog fragment, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1)) (if applicable)
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@petar-qb petar-qb added Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed Component: Tests 🧪 Issue/PR that address test framework labels Oct 4, 2023
@petar-qb petar-qb self-assigned this Oct 4, 2023
…087/action_loop_and_callback_mapping_tests
@huong-li-nguyen huong-li-nguyen requested review from chiara-sophie and removed request for huong-li-nguyen October 4, 2023 17:00
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, we are getting there! Have some comments for discussion

Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this looks good, but I'm not really familiar enough with the actions and actions tests to offer a very thorough review unfortunately. Increasing test coverage is always good anyway!

I left some questions that would help me understand a bit better though, and probably after that I'll be happy to approve 🙂

Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the updates to this, looks really good now 💯

Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, have a few more suggestions, but feel free to ignore the ones you don't like

@petar-qb petar-qb merged commit c5202f7 into main Oct 10, 2023
25 checks passed
@petar-qb petar-qb deleted the tests/1087/action_loop_and_callback_mapping_tests branch October 10, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tests 🧪 Issue/PR that address test framework Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants