-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action loop and callback mapping tests #93
Action loop and callback mapping tests #93
Conversation
…087/action_loop_and_callback_mapping_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, we are getting there! Have some comments for discussion
vizro-core/tests/unit/vizro/actions/_action_loop/test_get_action_loop_components.py
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_action_loop/test_get_action_loop_components.py
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_action_loop/test_get_action_loop_components.py
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell this looks good, but I'm not really familiar enough with the actions and actions tests to offer a very thorough review unfortunately. Increasing test coverage is always good anyway!
I left some questions that would help me understand a bit better though, and probably after that I'll be happy to approve 🙂
vizro-core/tests/unit/vizro/actions/_action_loop/test_get_action_loop_components.py
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_action_loop/test_get_action_loop_components.py
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_action_loop/test_get_action_loop_components.py
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
vizro-core/src/vizro/actions/_callback_mapping/_callback_mapping_utils.py
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
…087/action_loop_and_callback_mapping_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the updates to this, looks really good now 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, have a few more suggestions, but feel free to ignore the ones you don't like
Description
False
object is treated as all targets set.Screenshot
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
(if applicable)Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":