-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow None/Optional parameters #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into bug/allow_none_parameters
maxschulz-COL
requested review from
Joseph-Perkins,
antonymilne and
huong-li-nguyen
as code owners
October 4, 2023 16:44
maxschulz-COL
changed the title
Bug/allow none parameters
Allow None/Optional parameters
Oct 4, 2023
maxschulz-COL
added
Status: Ready for Review ☑️
Issue/PR is ready for review - all tests have passed
Component: Configuration 💻
Issue/PR that addresses changes in the configuration (public API)
labels
Oct 4, 2023
1 task
petar-qb
reviewed
Oct 5, 2023
petar-qb
reviewed
Oct 5, 2023
vizro-core/changelog.d/20231004_184107_maximilian_schulz_allow_none_parameters.md
Outdated
Show resolved
Hide resolved
antonymilne
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks great, just a few small comments! ⭐
vizro-core/changelog.d/20231004_184107_maximilian_schulz_allow_none_parameters.md
Outdated
Show resolved
Hide resolved
…_none_parameters.md Co-authored-by: Antony Milne <49395058+antonymilne@users.noreply.github.com> Signed-off-by: Maximilian Schulz <83698606+maxschulz-COL@users.noreply.github.com>
Co-authored-by: Antony Milne <49395058+antonymilne@users.noreply.github.com> Signed-off-by: Maximilian Schulz <83698606+maxschulz-COL@users.noreply.github.com>
… into bug/allow_none_parameters
antonymilne
approved these changes
Oct 6, 2023
petar-qb
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job. ✅
I just left one heads-up in a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Configuration 💻
Issue/PR that addresses changes in the configuration (public API)
Status: Ready for Review ☑️
Issue/PR is ready for review - all tests have passed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NONE
(the string) as a valid parameters option, which gets converted intoNone
Screenshot
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
(if applicable)Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":