Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no perfdata on connection_status and updates #102

Closed
MarcusCaepio opened this issue Oct 26, 2020 · 4 comments · Fixed by #103
Closed

no perfdata on connection_status and updates #102

MarcusCaepio opened this issue Oct 26, 2020 · 4 comments · Fixed by #103
Assignees
@mcktr
Labels
area/check/connection area/performance-data bug Something is wrong
Milestone
1.2.1

Comments

@MarcusCaepio
Copy link

Coming from tr64, where connection status and updates also gave perfdata, it seems, that check_fritz don't.
Would be nice, to have it again.

Cheers,
Marcus
@mcktr mcktr self-assigned this Oct 26, 2020
@mcktr mcktr added this to the 1.3.0 milestone Oct 26, 2020
@mcktr mcktr added bug Something is wrong area/performance-data labels Oct 26, 2020
mcktr added a commit that referenced this issue Oct 26, 2020
@mcktr
Add performance data output to connection_status
723eadc 
Adds the missing performance data output to the connection_status
method.

refs #102
mcktr added a commit that referenced this issue Oct 26, 2020
@mcktr
Add performance data output to device_update
e323786 
This adds the missing performance data output to the device_update
method.

refs #102
@mcktr mcktr mentioned this issue Oct 26, 2020
Merged
@mcktr mcktr closed this as completed in #103 Nov 2, 2020
@MarcusCaepio
Copy link
Author

hey, when will you release 1.3 with this merge? I just had an internet breakdown and I want to track the connection status for my ISP in the influxDB :) and thanks for the perfdata :D

@mcktr
Copy link
Owner

mcktr commented Nov 5, 2020

Since this is a bug I can prepare a bugfix release v1.2.1 tomorrow which will include this patch.

@mcktr mcktr modified the milestones: 1.3.0, 1.2.1 Nov 5, 2020
mcktr added a commit that referenced this issue Nov 7, 2020
@mcktr
Fix connection_status performance data output
edf9c55 
Handle Connecting and Authenticating as warning

refs #102
refs #103
@mcktr mcktr mentioned this issue Nov 7, 2020
Merged
mcktr added a commit that referenced this issue Nov 7, 2020
@mcktr
Add performance data output to device_update
9b7abd0 
This adds the missing performance data output to the device_update
method.

refs #102
mcktr added a commit that referenced this issue Nov 7, 2020
@mcktr
Add performance data output to connection_status
4d37bd6 
Adds the missing performance data output to the connection_status
method.

refs #102
mcktr added a commit that referenced this issue Nov 7, 2020
@mcktr
Fix connection_status performance data output
1105244 
Handle Connecting and Authenticating as warning

refs #102
refs #103
@mcktr
Copy link
Owner

mcktr commented Nov 7, 2020

@MarcusCaepio Release v1.2.1 is done :-)

@MarcusCaepio
Copy link
Author

Hey @mcktr
finally had the time to import the new version.
Looks fine, thanks a lot!

Cheers,
Marcus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcktr mcktr

Labels
area/check/connection area/performance-data bug Something is wrong
Projects
None yet
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

Missing performance data output in connection_status & device_update methods mcktr/check_fritz
2 participants
@MarcusCaepio @mcktr