Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero thresholds should be ignore #13

Closed
mcktr opened this issue Jan 24, 2019 · 0 comments · Fixed by #14
Closed

Zero thresholds should be ignore #13

mcktr opened this issue Jan 24, 2019 · 0 comments · Fixed by #14
Assignees
@mcktr
Labels
bug Something is wrong
Milestone
1.0

Comments

@mcktr
Copy link
Owner

mcktr commented Jan 24, 2019

Since we set zero as default threshold we should ignore them as this would break warning/critical calculation.

check_fritz (master) $ go run cmd/check_fritz/*.go --hostname 192.168.178.1 --password [###] --method downstream_current
CRITICAL - Current Downstream: 0.00 Mbit/s 
exit status 2
@mcktr mcktr added the bug Something is wrong label Jan 24, 2019
@mcktr mcktr added this to the 1.0 milestone Jan 24, 2019
mcktr added a commit that referenced this issue Jan 27, 2019
@mcktr
Set default thresholds to -1 and ignore them
a134d56 
This set the default values for the thresholds to -1 and ignore them in
check functions.

refs #13
@mcktr mcktr mentioned this issue Jan 27, 2019
Merged
@mcktr mcktr self-assigned this Jan 27, 2019
@mcktr mcktr closed this as completed in #14 Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcktr mcktr

Labels
bug Something is wrong
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Set default thresholds to -1 and ignore them mcktr/check_fritz
1 participant
@mcktr