Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken status/linkuptime functions on FritzBox cabel models #30

Closed
matthenning opened this issue Nov 11, 2017 · 7 comments · Fixed by #44
Closed

Broken status/linkuptime functions on FritzBox cabel models #30

matthenning opened this issue Nov 11, 2017 · 7 comments · Fixed by #44
Assignees
@mcktr
Labels
bug
Milestone
2.2

Comments

@matthenning
Copy link

Hello,

the script always returns UNKNOWN - Could not get a response | status=3 for me.
-d claims I'm using the wrong password, which I can rule out as I'm using the same credentials to log into the webinterface using copy&paste:

./check_tr64_fritz -d -h fritz.box -p 49443 -u redacted -P redacted -f status

<HTML>
  <HEAD>
    <TITLE>401 Unauthorized (ERR_ACCESS_DENIED)</TITLE>
  </HEAD>
  <BODY>
    <H1>401 Unauthorized</H1><BR>ERR_ACCESS_DENIED<HR><B>Webserver</B> Sat, 11 Nov 2017 15:46:31 GMT
  </BODY>
</HTML>

Oddly enough the reponse looks very different when I remove -d:

./check_tr64_fritz -h fritz.box -p 49443 -u redacted -P redacted -f status


<?xml version="1.0"?>
<s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/" s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
  <s:Body>
    <s:Fault>
      <faultcode>s:Client</faultcode>
      <faultstring>UPnPError</faultstring>
      <detail>
        <UPnPError xmlns="urn:dslforum-org:control-1-0">
          <errorCode>402</errorCode>
          <errorDescription>Invalid Args</errorDescription>
        </UPnPError>
      </detail>
    </s:Fault>
  </s:Body>
</s:Envelope>

Environment:
FritzBox 6360 Cable (Kabel Deutschland)
FRITZ!OS 06.54
@matthenning
Copy link
Author

matthenning commented Nov 11, 2017 •
edited
Loading

Some functions seem to be working fine though:

Working: uptime, upstreamrate, upstream, downstreamrate, downstream
Broken: status (see OP), linkuptime (could not parse output)

@mcktr mcktr self-assigned this Nov 11, 2017
@mcktr mcktr added the bug label Nov 11, 2017
@mcktr
Copy link
Owner

mcktr commented Nov 11, 2017

Hi.

you are using a Fritz!Box cable model and I guess that the information for the status and linkuptime function are not retrievable in the same way as on a "normal" Fritz!Box DSL model.

Both functions (status and linkuptime) are using the same TR-064 request to get the information, basically they retrieve information about WAN PPP and this is the problem I guess, on a cable model you don't have this, because the connection method is not PPPoE.

I don't have access to an Fritz!Box cable model nor to a cable connection, so I can't looking into the details of the the TR-064 interface of such a Fritz!Box model. To figure out how they provide the needed information and for developing a fix for it, I could need your help (if you want) :)

First step is to figure out which TR-064 information a Fritz!Box cable model have, go to http://<FRITZ BOX ADRESSE>:49000/tr64desc.xml and copy the entire page and send it to me. Because I do not know, if there are any private information inside page (MAC-Address, Serial numbers, ... ) please send it via e-mail to me.

@mcktr mcktr changed the title Invalid Args error Broken status/linkuptime functions on FritzBox cabel models Nov 11, 2017
@matthenning
Copy link
Author

matthenning commented Nov 11, 2017 •
edited
Loading

E-Mail is sent. There doesn't seem to be confidential data included at first glance.
If there is any more info required or tests to be done just let me know. I'm happy to help.

@mcktr mcktr added this to the 2.2 milestone Nov 11, 2017
@mcktr
Copy link
Owner

mcktr commented Nov 13, 2017

Thanks a lot! 👍

You should have a mail with instructions for further tests.

@matthenning
Copy link
Author

I got the mail, thank you. I'll get back to you as soon as time allows it in the next few days.

@uclara
Copy link

uclara commented Nov 26, 2017

Hi mcktr,

I have the same issue with my FRITZ!Box 6490 Cable. If you want I can also perform these tests.

Ulli

mcktr added a commit that referenced this issue Nov 26, 2017
@mcktr
Fix status/linkuptime functions for FritzBox cabel
991c0c5 
This implements a fix for the functions status & linkuptime to check FritzBox cabel models. It is now possible to set the connection type. Example "status:cabel" or "linkuptime:cable". The default behaviour is to check PPPoE connection types (same as beforehand), so we don't break any existing setup.

refs #30
@mcktr mcktr mentioned this issue Nov 26, 2017
Merged
@mcktr
Copy link
Owner

mcktr commented Nov 26, 2017

Please have a look into the linked Pull Request. :)

@mcktr mcktr closed this as completed in #44 Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcktr mcktr

Labels
bug
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

Fix status/linkuptime functions for FritzBox cable mcktr/check_tr64_fritz
3 participants
@uclara @matthenning @mcktr