Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting files from 7z with old compression makes it a ZSTD archive #277

Closed
Luashine opened this issue Oct 22, 2022 · 4 comments
Closed

Comments

@Luashine
Copy link

Luashine commented Oct 22, 2022

Version: 7-Zip 19.00 ZS v1.4.8 R1 x64 and 7-Zip 21.03 ZS v1.5.0 R2 x64

  1. Create a 7z archive with old compression to share with the world
  2. Notice a mistake, delete a file/folder inside
  3. The archive has now the ZSTD compression method, impossible to open in default 7-Zip (click the INFO icon on the top-right)

Expected: modifying the archive with 7-Zip ZSTD does not introduce new compression algorithms that'd "break" the file for other users.

This seems to be similar to #111 where an archive is modified by drag-and-drop.

PS and Update: in #111 I read that this fork should save the last setting in registry. Instead it should check what compression algorithm is used in the archive and use the same algorithm for operations.

First accident:
7z-zstd

Reproduction, original archive:
original-archive
Same archive after deleting a folder:
files-or-folders-deleted

@Vangelis66
Copy link

Related: #263

@mcmilk
Copy link
Owner

mcmilk commented Jan 15, 2023

Can you re-check this with latest pre-release ...

@Luashine
Copy link
Author

@mcmilk with latest pre-release (v22.01-v1.5.2-R1).

Severe bug: when I compress files with "LZMA2 [std]" then the resulting archive reports "Method ZSTD:v1.5,l2" - where "l2" is the selected LZMA2 Compression level and Info - Method says "ZSTD". WinRAR cannot extract such an archive, I suppose it's really not the default LZMA2 = its not a display error.

LZMA2 Fast compresses correctly into LZMA2. Other algorithms works correctly, only LZMA2 std does not.

@mcmilk
Copy link
Owner

mcmilk commented Jan 20, 2023

Okay, I will re-check this with that provided info.

mcmilk added a commit that referenced this issue Feb 12, 2023
mcmilk added a commit that referenced this issue Feb 12, 2023
@mcmilk mcmilk closed this as completed Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants