Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceId hardcoded as "crs" #7

Open
sporkd opened this issue Jan 29, 2010 · 3 comments
Open

ServiceId hardcoded as "crs" #7

sporkd opened this issue Jan 29, 2010 · 3 comments
Labels

Comments

@sporkd
Copy link

sporkd commented Jan 29, 2010

Howdy,

It appears the ServiceId is hardcoded to "crs" inside the WLS_VERSION hash. However ShipService_v7.wsdl requires ServiceId to be set to "ship". Is there a way to override this? If not it appears that only rate has been tested, and a patch will be necessary for label to work.

Peter

@mcmire
Copy link
Owner

mcmire commented Jan 29, 2010

Thanks for letting me know. You're right that I've only really tested the rate service, and I apologize for not having proper tests (I'm working toward that point). There may be a way to override the ServiceId, in fact -- try this:

fedex.label(:Version => { :Major => 7, :Intermediate => 0, :Minor => 0, :ServiceId => "ship" }, ...)

I'd guess that you'd probably have to do the same thing for .cancel as well. I'll work on making this automatic for .ship and .cancel, shouldn't be too much trouble.

@mcmire
Copy link
Owner

mcmire commented Oct 28, 2010

This is fixed in kdonovan's fork, I just need to pull it in...

@sporkd
Copy link
Author

sporkd commented Oct 28, 2010

Cool. I think kdonovan already merged in all my changes as well, so merging with her branch will get you this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants