Remove instance_eval from InspectionTree #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
remove-instance-eval-from-inspection-tree
branch
2 times, most recently
from
dbe1a0f
to
6a3d2df
Compare
The InspectionTree class defines methods that create nodes in the tree. Some of these methods take a block which is `instance_eval`'ed inside of a new subtree. This use of `instance_eval` may seem to create a very clean and easy to use API on the surface, but it quickly breaks down if, as you are defining your InspectionTree, you need to extract methods inside of your InspectionTreeBuilder and then reference them. _Not_ `instance_eval`'ing creates footguns, but it also removes the magic and mystery around how InspectionTree works.
mcmire
force-pushed
the
remove-instance-eval-from-inspection-tree
branch
from
6a3d2df
to
e672450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InspectionTree class defines methods that create nodes in the tree. Some of these methods take a block which is
instance_eval'ed inside of a new subtree. This use ofinstance_evalmay seem to create a very clean and easy to use API on the surface, but it quickly breaks down if, as you are defining your InspectionTree, you need to extract methods inside of your InspectionTreeBuilder and then reference them. Notinstance_eval'ing creates footguns, but it also removes the magic and mystery around how InspectionTree works.