Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using yellow and magenta across the board instead of red and green #42

Closed
mcmire opened this issue Sep 19, 2019 · 1 comment
Closed

Consider using yellow and magenta across the board instead of red and green #42

mcmire opened this issue Sep 19, 2019 · 1 comment
Milestone
v0.2.0

Comments

@mcmire
Copy link
Owner

mcmire commented Sep 19, 2019

Red and green connote good and bad. It means that the "actual" value is correct and the "expected" value is not. Well, who's to say? Sometimes it's the other way around. So maybe we shouldn't use overloaded colors in this way.
@mcmire mcmire added this to the v0.2.0 milestone Sep 19, 2019
@mcmire
Copy link
Owner Author

mcmire commented Oct 3, 2019

Addressed in fed6227.

@mcmire mcmire closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@mcmire