Fix some docutils mypy warnings.

mcmtroffaes · Feb 8, 2022 · deaec6d · deaec6d
1 parent 428d0c1
commit deaec6d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/sphinxcontrib/bibtex/transforms.py b/src/sphinxcontrib/bibtex/transforms.py
@@ -5,6 +5,7 @@
         .. autoattribute:: default_priority
         .. automethod:: run
 """
+from itertools import zip_longest
 
 import docutils.nodes
 
@@ -25,15 +26,15 @@
 
 def node_text_transform(node: docutils.nodes.Element) -> None:
     """Apply extra text transformations to a node."""
-    for child, next_child in zip(node.children[:], node.children[1:] + [None]):
+    for child, next_child in zip_longest(node.children[:], node.children[1:]):
         if isinstance(child, docutils.nodes.Text):
             if (child.endswith(r'\url ')
                     and isinstance(next_child, docutils.nodes.Text)):
                 node.replace(child, docutils.nodes.Text(child[:-5]))
                 ref_node = docutils.nodes.reference(refuri=next_child.astext())
                 ref_node += next_child
                 node.replace(next_child, ref_node)
-        else:
+        elif isinstance(child, docutils.nodes.Element):
             node_text_transform(child)
 
 

diff --git a/test/natbib.py b/test/natbib.py
@@ -291,7 +291,8 @@ def result_nodes(self, document: nodes.document, env: BuildEnvironment,
                 'global_keys': env.domaindata['cite']['keys'],
                 'config': config}
 
-        node += nodes.pending(CitationTransform, data)
+        # TODO bad design here, pending is meant to get the Transform object
+        node += nodes.pending(CitationTransform, data)  # type: ignore
         return [node], []