Fix tests failures with Sphinx 1.7 by always registering the transform #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One test is failing on Python 2.7 because Tinkerer dropped Python 2 support in vladris/tinkerer@d3aee0119290afc2, that is unrelated to my changes. |
|
Oh, thanks for this! I'm trying to understand why this is needed - it looks like a bug in sphinx? |
|
I would say the previous Sphinx behavior was a bug, and this project had a hack to work around it, a part of which is no longer needed with the new version. |
|
Yeah, agreed. 👍 I'm releasing it in a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sphinx-doc/sphinx@27ea988f6e5a6637, the transforms handling has been moved into a registry, so the list of transforms no longer persists between tests runs.