Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only half screen is used in landscape mode #9

Closed
obromios opened this issue Apr 30, 2016 · 5 comments
Closed

Only half screen is used in landscape mode #9

obromios opened this issue Apr 30, 2016 · 5 comments
Labels

Comments

@obromios
Copy link

When I unlock the device orientation and allow the device to go landscape mode, the app only fills the left half the screen, the rest is blank. How do I fix this?

Also, maybe related, when I rotate the screen so it goes back to portrait view, sometimes it shows a unrotated portrait mode.

See below for examples screen shots.

By the way, I have found this app very useful. Thank you.

screen shot 2016-05-01 at 9 06 26 am

screen shot 2016-05-01 at 9 06 08 am

@mcnamee
Copy link
Owner

mcnamee commented May 1, 2016

Hi, I'm on holidays away from my computer for the next few days, but will take a look when I return.

If you find a fix in the meantime, feel free to submit a pull request.

Matt

@mcnamee mcnamee added the bug label May 1, 2016
@obromios
Copy link
Author

Does this answer on stackoverflow point in the right direction to solve this problem?

@mcnamee
Copy link
Owner

mcnamee commented May 24, 2016

Hi @obromios
Sorry for the delay! I've just pushed an upgrade which resolves this. Basically, RN calculates the windowWidth on load and you have to manually ask it to recalculate for things like orientation change.
Instead of doing this, I simply rewrote the styles to use flexbox - which is the better way to do it anyway.

Thanks for raising the issue, to push me along

@mcnamee mcnamee closed this as completed May 24, 2016
@obromios
Copy link
Author

Thank you, I will try it in the next few days and let you know how it goes.

Flexbox fantastic, for the first time I am not dreading having to locate
any elements with CSS.

On Tue, May 24, 2016 at 7:18 PM, Matt Mcnamee notifications@github.com
wrote:

Hi @obromios https://github.com/obromios
Sorry for the delay! I've just pushed an upgrade which resolves this.
Basically, RN calculates the windowWidth on load and you have to manually
ask it to recalculate for things like orientation change.
Instead of doing this, I simply rewrote the styles to use flexbox - which
is the better way to do it anyway.

Thanks for raising the issue, to push me along


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9 (comment)

@obromios
Copy link
Author

That worked thank you. Elegant solution ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants