Extending API with URL Params for Parts of Speech #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wing users to refine their word search with adjectives, nouns, sentences, verbs, etc.
Route params feature added for more fine tuned results
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The PR has been merged. Thanks for the huge contribution ❤️ |
|
@all-contributors please add @jonah-butler for code |
|
I've put up a pull request to add @jonah-butler! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I swapped out my last PR with query params for URL params. In addition to the new route in en.js, I also updated the readme with some info about the available endpoint options. You may want to display that differently, but I figured I would add it in so you didn't have to go through all of randomword.com and copy those route parameters!
I tested all possible route options, and they are working too. 🤟
Let me know if you think it needs anything else or some kind of cleaning up - I'm happy to knock that out. 🙏