Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Use bloom filters to detect request of expired notes #11

Closed
mcndt opened this issue Aug 8, 2022 · 1 comment
Closed

[Feature] Use bloom filters to detect request of expired notes #11

mcndt opened this issue Aug 8, 2022 · 1 comment
Labels

Comments

@mcndt
Copy link
Owner

mcndt commented Aug 8, 2022

  • Improved UX: user knows that the link has expired instead of containing a typo
  • Good perf: check if note ID has ever existed in O(1) time

Use e.g. https://www.npmjs.com/package/bloom-filters

@mcndt mcndt added the feature label Aug 8, 2022
@mcndt
Copy link
Owner Author

mcndt commented Aug 11, 2022

Shipped in #18

@mcndt mcndt closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Shipped
Development

No branches or pull requests

1 participant