Skip to content

Commit

Permalink
Remove redundant nuget packages and assembly binding redirects
Browse files Browse the repository at this point in the history
The System.Net.Http nuget packages and assembly binding redirects were preventing compute from running in docker. The issues started when a few of Rhino's core libraries were updated to .NET 4.8. The nuget packages and assembly binding redirects were added in 7c7bcae and are no longer necessary. System.Net.Http is now referenced directly from the .NET Framework.
  • Loading branch information
pearswj committed Aug 23, 2020
1 parent b67137c commit 33f6b38
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 56 deletions.
2 changes: 2 additions & 0 deletions .dockerignore
@@ -0,0 +1,2 @@
**/obj/
**/bin/
22 changes: 1 addition & 21 deletions src/compute.frontend/App.config
Expand Up @@ -3,24 +3,4 @@
<startup>
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.2" />
</startup>
<runtime>
<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
<dependentAssembly>
<assemblyIdentity name="System.Interactive.Async" publicKeyToken="94bc3704cddfc263" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-3.0.3000.0" newVersion="3.0.3000.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-4.1.1.0" newVersion="4.1.1.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="Google.Apis.Auth" publicKeyToken="4b01fa6e34db77ab" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-1.30.0.0" newVersion="1.30.0.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="Google.Apis.Auth.PlatformServices" publicKeyToken="4b01fa6e34db77ab" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-1.30.0.0" newVersion="1.30.0.0" />
</dependentAssembly>
</assemblyBinding>
</runtime>
</configuration>
</configuration>
9 changes: 2 additions & 7 deletions src/compute.frontend/compute.frontend.csproj
Expand Up @@ -44,6 +44,7 @@
<Reference Include="Microsoft.CSharp" />
<Reference Include="System.Data" />
<Reference Include="System.Xml" />
<Reference Include="System.Net.Http" />
</ItemGroup>
<ItemGroup>
<Compile Include="Authentication\ApiKey.cs" />
Expand Down Expand Up @@ -93,12 +94,6 @@
<PackageReference Include="Serilog.Sinks.File">
<Version>4.0.0</Version>
</PackageReference>
<PackageReference Include="System.Interactive.Async">
<Version>3.1.1</Version>
</PackageReference>
<PackageReference Include="System.Net.Http">
<Version>4.3.1</Version>
</PackageReference>
<PackageReference Include="Topshelf">
<Version>4.1.0</Version>
</PackageReference>
Expand All @@ -114,4 +109,4 @@
</ItemGroup>
<Delete Files="@(FilesToDelete)" />
</Target>
</Project>
</Project>
22 changes: 1 addition & 21 deletions src/compute.geometry/App.config
Expand Up @@ -3,24 +3,4 @@
<startup>
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.2" />
</startup>
<runtime>
<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
<dependentAssembly>
<assemblyIdentity name="System.Interactive.Async" publicKeyToken="94bc3704cddfc263" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-3.0.3000.0" newVersion="3.0.3000.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-4.1.1.0" newVersion="4.1.1.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="Google.Apis.Auth" publicKeyToken="4b01fa6e34db77ab" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-1.30.0.0" newVersion="1.30.0.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="Google.Apis.Auth.PlatformServices" publicKeyToken="4b01fa6e34db77ab" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-1.30.0.0" newVersion="1.30.0.0" />
</dependentAssembly>
</assemblyBinding>
</runtime>
</configuration>
</configuration>
8 changes: 1 addition & 7 deletions src/compute.geometry/compute.geometry.csproj
Expand Up @@ -115,12 +115,6 @@
<PackageReference Include="Serilog.Sinks.File">
<Version>4.0.0</Version>
</PackageReference>
<PackageReference Include="System.Interactive.Async">
<Version>3.1.1</Version>
</PackageReference>
<PackageReference Include="System.Net.Http">
<Version>4.3.1</Version>
</PackageReference>
<PackageReference Include="Topshelf">
<Version>4.1.0</Version>
</PackageReference>
Expand All @@ -136,4 +130,4 @@
</ItemGroup>
<Delete Files="@(FilesToDelete)" />
</Target>
</Project>
</Project>

0 comments on commit 33f6b38

Please sign in to comment.