Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Plane property on BND_Arc #480

Merged
merged 2 commits into from Sep 18, 2022
Merged

Conversation

coditect
Copy link
Contributor

This pull request exposes the Plane and Normal properties of Arc objects, as well as a setter for the Arc property of ArcCurve.

@sbaer
Copy link
Member

sbaer commented Sep 18, 2022

I would remove Arc.Normal and ArcCurve.Arc (setter). I'm trying to keep this library as close to what we have in RhinoCommon as possible.
https://developer.rhino3d.com/api/RhinoCommon/html/Properties_T_Rhino_Geometry_Arc.htm
https://developer.rhino3d.com/api/RhinoCommon/html/P_Rhino_Geometry_ArcCurve_Arc.htm

@coditect
Copy link
Contributor Author

I'll remove them for the sake of consistency, but I think they would be worthwhile additions to RhinoCommon because:

  • Circle has a Normal property, so why not Arc (which is a subclass of Circle in openNURBS)?
  • LineCurve.Line has both a getter and setter, so why not ArcCurve.Arc?

@coditect coditect changed the title Expose plane and normal properties on BND_Arc Expose Plane property on BND_Arc Sep 18, 2022
@sbaer
Copy link
Member

sbaer commented Sep 18, 2022

Documentation for this project is created by scraping the RhinoCommon API documentation. If we add properties, we need to start with RhinoCommon and then add them to this project. It really is just a matter of consistency.

@sbaer sbaer merged commit 42df3b4 into mcneel:main Sep 18, 2022
@coditect coditect deleted the arc-properties branch September 20, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants