This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
new dev ci-cd #45
Merged
new dev ci-cd #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
KeeyanGhoreshi,
kennyEung,
plarocque4 and
zacharyrobin
kennyEung
reviewed
Nov 1, 2022
kennyEung
reviewed
Nov 1, 2022
This was referenced Nov 2, 2022
kennyEung
approved these changes
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR accomplishes two things: setting up the dev branch for future use by the development team and renaming the master branch to main. Both of these have corresponding ci-cd changes as part of this pull request. There were also some GitHub setting that were modified that effect workflow including branch protection rules, optional auto-merge functionality once the PR gets reviewed, additional requirements for the PR to be up to date with the base branch as well as have all conversations resolved, and finally branch automatic deletion after PR merge (branches can still be revived and their data and changes are not lost). There is a similar PR set up in mostly all other REMS repositories as well (mcode/pharmacy-information-system#21, mcode/CRD#51, mcode/CDS-Library#22, mcode/test-ehr#33, mcode/request-generator#27, #45).
Issue ticket number and Jira link
REMS-291: https://jira.mitre.org/browse/REMS-291
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.