Unauthenticated connection will unregister the current connected one #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failed with But it is not my case. The master branch also failed with this one. |
|
Would you mind adding a unit test? --- We'll need a fix for the failing test as well. |
|
done :) |
|
@seeLuck there is one test that is failing not ok 335 one connected clients
---
operator: equal
expected: 1
actual: 2
at: <anonymous> (/home/travis/build/mcollina/aedes/test/meta.js:30:11)
stack: |-
Error: one connected clients
at Test.assert [as _assert] (/home/travis/build/mcollina/aedes/node_modules/tape/lib/test.js:225:54)
at Test.bound [as _assert] (/home/travis/build/mcollina/aedes/node_modules/tape/lib/test.js:77:32)
at Test.equal (/home/travis/build/mcollina/aedes/node_modules/tape/lib/test.js:385:10)
at Test.bound [as equal] (/home/travis/build/mcollina/aedes/node_modules/tape/lib/test.js:77:32)
at /home/travis/build/mcollina/aedes/test/meta.js:30:11
at _combinedTickCallback (internal/process/next_tick.js:132:7)
at process._tickCallback (internal/process/next_tick.js:181:9)
... |
|
@robertsLando |
|
There was some problem with tests that have been fixed by a recent PR, now should be good
… On 19 Dec 2019, at 03:21, seeLuck ***@***.***> wrote:
@robertsLando
It seems not mine problem, I just merge the branch and all passed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@mcollina |
|
Landed, I hope I can get a new release out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix bug:
Two connection with same client id. Connection A passed
authenticateand connect to broker successfully. Connection B reject byauthenticateand failed to connect to broker.While with this failed Connection B, the current client info will be unregisted in broker.
Few lines to fix it.