Only use setImmediate if it is defined #137
Conversation
Possibly, though it may involve a lot of extra setup/dependencies. I can look into it more soon, probably early next week |
|
@mcollina I've added a test that uses wrangler, which is the documented way to use the |
|
|
||
| const sleep = promisify(setTimeout) | ||
|
|
||
| describe('storage memory (cloudflare)', async () => { |
There was a problem hiding this comment.
can you please skip this in Node.js v18.6? it's failing on CI
There was a problem hiding this comment.
Skipped in c774406
There was a problem hiding this comment.
Looks like it's still not skipping the suite in 18 - perhaps before is still being run for the suite? I'm sorry, this is my first experience with node:test, and I'm not entirely certain how to solve this
There was a problem hiding this comment.
Although it appears to be documented for v18, I couldn't get the option to work when running 18.19.0 locally. I just put the whole describe in an if block in d1a4ed7, and ran it locally against v18.19.0
| await worker.stop() | ||
| }) | ||
|
|
||
| test('able to invalidate without error', async () => { |
There was a problem hiding this comment.
This test doesn't assert that invalidation works, since the function in the helper returns always an empty object, doesn't it?
What should or should not happen? Throwing/not throwing an error, returning a different value, other?
There was a problem hiding this comment.
It should get a response from the cloudflare worker without encountering an error. The delay is simply to trigger invalidation in the worker.mjs code. I have changed the description of the test to clarify this intent in fb9dda1
There was a problem hiding this comment.
Thanks, more clear now. Could you use assert.doesNotThrow?
There was a problem hiding this comment.
I used doesNotReject (since it's async) in a3741e5
This PR changes the strategy used to determine if
setImmediateis available, which should allow the library to work correctly on other non-Node runtimes such as cloudflare workers.Fixes #136