-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use storage and invalidation #7
Conversation
still have to write test on storage and reach 100% coverage |
great work! |
I'm collecting on top all the points |
0e826d5
to
966a17e
Compare
abd5cdf
to
aa3026f
Compare
8a8b6f5
to
0e55910
Compare
@mcollina wait to review, still a wip |
looks good! |
2e375d1
to
30d123d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs lots of docs, specifically how to use references
I'm thinking of doing am extended use case in wdyt? |
Just do one and copy it over/adapt here. I think this deserves some docs anyway. |
@mcollina apart of documentation, the code is done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create a "Maintainers" Section on the README and add both yourself and myself there? This module is as much yours as it is mine now.
Also add yourself to the package.json too.
@mcollina done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
proposal for use of an external storage, with optional invalidation
TODO
storage gc functionuse a btree? a set?arrays are good enough