Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test on Node v6 #11

Closed
GlenTiki opened this issue Jun 22, 2016 · 3 comments
Closed

Failing test on Node v6 #11

GlenTiki opened this issue Jun 22, 2016 · 3 comments
Assignees

Comments

@GlenTiki
Copy link
Collaborator

GlenTiki commented Jun 22, 2016

Issue seems to stem from hdr histogram. Testing as appropriate, will report findings after.

Output:

Glens-MacBook-Pro-2:autocannon glen$ npm run test

> autocannon@0.5.2 test /Users/glen/work/nearform/os/autocannon
> standard && tap test/*.test.js

test/format.test.js ................................... 4/4
test/myhttp.test.js ................................. 29/29
test/run.test.js .................................... 47/48
  run
  not ok throughput.stddev exists
    at:
      line: 34
      column: 7
      file: test/run.test.js
    stack: |
      test/run.test.js:34:7
      Timeout.setInterval (lib/run.js:100:7)
    source: |
      t.ok(result.throughput.stddev, 'throughput.stddev exists')

total ............................................... 80/81


  80 passing (5s)
  1 failing


npm ERR! Darwin 15.5.0
npm ERR! argv "/Users/glen/.nvm/versions/node/v6.2.2/bin/node" "/Users/glen/.nvm/versions/node/v6.2.2/bin/npm" "run" "test"
npm ERR! node v6.2.2
npm ERR! npm  v3.9.5
npm ERR! code ELIFECYCLE
npm ERR! autocannon@0.5.2 test: `standard && tap test/*.test.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the autocannon@0.5.2 test script 'standard && tap test/*.test.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the autocannon package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     standard && tap test/*.test.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs autocannon
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls autocannon
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/glen/work/nearform/os/autocannon/npm-debug.log
@GlenTiki GlenTiki self-assigned this Jun 22, 2016
@mcollina
Copy link
Owner

It's not broken. The problem is that there might be that stddev is zero. The test should verify that it is a Number.

@GlenTiki
Copy link
Collaborator Author

Indeed you are correct. Do I need to patch/update tests?

@mcollina
Copy link
Owner

yes please :)

mcollina added a commit that referenced this issue Jun 22, 2016
Fixed #11: failing tests when stddev was === 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants