Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #16: can now pass customiseRequest to build custom requests per connection #22

Merged
merged 2 commits into from
Jun 25, 2016

Conversation

GlenTiki
Copy link
Collaborator

@GlenTiki GlenTiki commented Jun 24, 2016

This has the code, the docs and a sample. No unit tests right now however, I'm unsure how to test this.

fixes #16

@GlenTiki GlenTiki changed the title Fixed #19: can now pass customiseRequest to build custom requests per connection Fixed #16: can now pass customiseRequest to build custom requests per connection Jun 24, 2016
@mcollina
Copy link
Owner

You add a test into myhttp in which you use this to set a body or a header, and you check the server that those were set correctly.

@GlenTiki
Copy link
Collaborator Author

Cool, I'll add that 👍

@GlenTiki
Copy link
Collaborator Author

I didn't check the server, just verified that it overwrote the headers and body options passed in 👍

@mcollina mcollina merged commit 1567b53 into mcollina:master Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support a way to set headers and body before the client is started
2 participants