Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds support for HTTP basic authentication #220

Merged
merged 2 commits into from Nov 2, 2019
Merged

adds support for HTTP basic authentication #220

merged 2 commits into from Nov 2, 2019

Conversation

gillesdemey
Copy link
Contributor

fixes #213

mcollina
mcollina reviewed Oct 7, 2019
View reviewed changes
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding some docs as well?

lib/httpRequestBuilder.js Show resolved Hide resolved
@mcollina
Copy link
Owner

mcollina commented Nov 1, 2019

Any updates on this one?

@gillesdemey
Copy link
Contributor Author

I've just added an end-to-end test and also tested the negative case locally where the test fails if no credentials were passed via the URL.

mcollina
mcollina approved these changes Nov 2, 2019
View reviewed changes
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit ff89f98 into mcollina:master Nov 2, 2019
@gillesdemey gillesdemey deleted the fix/basic-auth branch November 2, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@GlenTiki GlenTiki GlenTiki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supporting Basic HTTP auth in URL
3 participants
@gillesdemey @mcollina @GlenTiki