Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #281
Now, request iterator resets when some of its
setupRequest()
returning falsey value (previously it the pipeline was simply crashing).But this may actually obfuscate bugs of the tested service: often
setupRequest()
fails as the previous response did not contained expected data.This PR simply displays how many times the pipeline reseted, so users could decide whether it is intended or not.
Note: I know
test/progressTracker.test.stub.js
isn't part of the test suite, but as I've changed it to troubleshoot the feature, I though it would be fine to keep a new test in it.The feature is properly covered in
est/httpClient.test.js
andtest/run.test.js
test files.Edit: this PR actually unveiled some flaws in the previous implementation.
Reseting request pipeline the way I did is wrong, as it may leave
currentRequest.requestBuffer
tonull
.This new version fixes the flaw, and also handle a specific case where the very first
setupRequest()
fails. In this situation, we can not reset pipeline (or it'll never end), and we must exit on an error.