Title json #44
Title json #44
Conversation
|
You know I'm asking you to add a unit test :) |
|
I added some assertions, not sure how else I could test that? Are those okay? :) |
| requests: histAsObj(requests, totalRequests), | ||
| latency: addPercentiles(latencies, histAsObj(latencies)), | ||
| throughput: histAsObj(throughput, totalBytes), | ||
| errors: errors, | ||
| timeouts: timeouts, | ||
| duration: Math.round((Date.now() - startTime) / 1000), | ||
| start: startTime, | ||
| finish: Date.now(), |
There was a problem hiding this comment.
I think we should have those as Date objects, rather than as epocs. Easier to print :).
There was a problem hiding this comment.
Epochs are easier for transmission/serialisation though, right? I'll create them as objects though if you want.
There was a problem hiding this comment.
please do, those output will very likely be consumed by humans, and Date do jsonify.
There was a problem hiding this comment.
start is still an epoch, you will need to convert it to a Date object: https://github.com/mcollina/autocannon/blob/master/lib/run.js#L79
There was a problem hiding this comment.
startTime needs to remain an epoch for the duration calculation, but I use new Date(startTime) to convert back to an object from the epoch. Do you want me to convert startTime to an object and then convert it to an epoch for the duration calculation? it's just two ways of achieving the same thing.
| requests: histAsObj(requests, totalRequests), | ||
| latency: addPercentiles(latencies, histAsObj(latencies)), | ||
| throughput: histAsObj(throughput, totalBytes), | ||
| errors: errors, | ||
| timeouts: timeouts, | ||
| duration: Math.round((Date.now() - startTime) / 1000), | ||
| start: new Date(startTime), | ||
| finish: new Date(), |
There was a problem hiding this comment.
@mcollina Here. I'm using new Date(value): https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Date
There was a problem hiding this comment.
oh I didn't see that. All good for me!
There was a problem hiding this comment.
No problem, we were still talking on the outdated diff 👍
fixes #43
Also found an issue where the timeout flag was missing.