This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
Server.subscribe #411
Closed
Server.subscribe #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would just throw in a little unit test for the new API. |
using newPacket instead of packet for publish
|
Any update on this? |
Proper Unsubscribe handling, fixes moscajs#405
|
I was busy @mcollina , sorry for being late, will update ASAP |
Changed docker base image to arrive at a much smaller container.
Changed docker base image
Added exception catch for invalid topics in mongo persistence
added default options to empty object
adding a Raspberry Pi specific Dockerfile
colons are allowed in a client id
|
Can I get a couple of tests for this, so I add it to #464 ? |
|
this PR seemed abit old, I created a new one based on your master #472 However there's also a conflict! I can't say why!? |
|
It's not based on latest master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide a subscribe method using ascoltatori backend. Closes #408