feat: simplify React support #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format Checker ReportAll files are correctly formatted |
mcollovati
force-pushed
the
feat/simplify-react-support
branch
2 times, most recently
from
5991570
to
dc95482
Compare
Dudeplayz
requested changes
Nov 26, 2023
...resources/com/github/mcollovati/quarkus/hilla/deployment/crud/panache/application.properties
Show resolved
Hide resolved
runtime-react/src/main/codestarts/quarkus/quakus-hilla-maven-codestart/base/README.tpl.qute.md
Outdated
Show resolved
Hide resolved
This change introduces the quarkus-hilla-react extension, to be used for application using React as front-end development framework. In addition, it also updates the codestarts to provide a working application, leveraging on Hilla scaffold utility. Fixes #393
Co-authored-by: Dario Götze <Dario@ok.de>
mcollovati
force-pushed
the
feat/simplify-react-support
branch
from
805e3c3
to
ca23046
Compare
causes infinite loop at runtime when Quarkus resolves dependencies
Dudeplayz
requested changes
Nov 28, 2023
There was a problem hiding this comment.
I would like to discuss the thing with the naming of the artifacts.
My suggestion was to add the react prefix simply to everything and not in between. So that simply by looking at the prefix it is clear, what it is targeting. I see the reason, why it is in between, because it is hilla-react targeting. How is hilla doing the naming of maven artifacts with the react thing?
...github/mcollovati/quarkus/hilla/deployment/SpringDiExtensionSupportReactiveEndpointTest.java
Show resolved
Hide resolved
...rc/test/resources/com/github/mcollovati/quarkus/hilla/deployment/test-application.properties
Outdated
Show resolved
Hide resolved
...rc/test/resources/com/github/mcollovati/quarkus/hilla/deployment/test-application.properties
Outdated
Show resolved
Hide resolved
...sources/com/github/mcollovati/quarkus/hilla/deployment/test-spring-di-application.properties
Outdated
Show resolved
Hide resolved
|
Hilla has Could you please show me the naming you are thinking about, by providing examples for all our artifacts? |
|
See the comments on the code, where I switched the 'react' tag to the end |
Dudeplayz
requested changes
Nov 28, 2023
Dudeplayz
reviewed
Nov 28, 2023
mcollovati
commented
Nov 28, 2023
Co-authored-by: Dario Götze <Dario@ok.de>
Dudeplayz
reviewed
Nov 28, 2023
runtime-commons/src/main/resources/META-INF/microprofile-config.properties
Show resolved
Hide resolved
Dudeplayz
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the quarkus-hilla-react extension, to be used for application using React as front-end development framework. In addition, it also updates the codestarts to provide a working application, leveraging on Hilla scaffold utility.
Fixes #393