Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt to new endpoint registry initialization #622

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

mcollovati
Copy link
Owner

Hilla endpoint registry is now eagerly initialized in a VaadinServiceInitListener. This change introduces an custom init listener to postpone the registry initialization in a method, to prevent application crash because Quarkus SecurityConfiguration required by security interceptor (e.g. for annotation) is not yet ready.

Fixes #604

Hilla endpoint registry is now eagerly initialized in a VaadinServiceInitListener.
This change introduces an custom init listener to postpone the registry initialization
in a  method, to prevent application crash because Quarkus SecurityConfiguration
required by security interceptor (e.g. for  annotation) is not yet ready.

Fixes #604
@quarkus-hilla-bot
Copy link
Contributor

Format Checker Report

All files are correctly formatted

Copy link

Test Results

 47 files  + 27   47 suites  +27   12m 47s ⏱️ + 10m 53s
166 tests +140  166 ✅ +166  0 💤  - 9  0 ❌ ±0 
221 runs  +195  221 ✅ +221  0 💤  - 9  0 ❌ ±0 

Results for commit 9576083. ± Comparison against base commit 26cc3cd.

This pull request removes 15 and adds 155 tests. Note that renamed tests count towards both.
com.github.mcollovati.quarkus.hilla.deployment.BrowserCallableControllerTest ‑ Unknown test
com.github.mcollovati.quarkus.hilla.deployment.EndpointControllerTest ‑ Unknown test
com.github.mcollovati.quarkus.hilla.deployment.EndpointSecurityTest ‑ Unknown test
com.github.mcollovati.quarkus.hilla.deployment.ReactiveEndpointTest ‑ Unknown test
com.github.mcollovati.quarkus.hilla.deployment.ReactiveSecureEndpointTest ‑ Unknown test
com.github.mcollovati.quarkus.hilla.deployment.SpringDataExtensionsSupportTest ‑ Unknown test
com.github.mcollovati.quarkus.hilla.deployment.SpringDiExtensionSupportReactiveEndpointTest ‑ Unknown test
com.github.mcollovati.quarkus.hilla.deployment.SpringDiExtensionsSupportTest ‑ Unknown test
com.github.mcollovati.quarkus.hilla.deployment.SpringReplacementsTest ‑ Unknown test
com.github.mcollovati.quarkus.hilla.deployment.crud.panache.CrudRepositoryServiceTest ‑ Unknown test
…
com.example.application.AutoCrudTest ‑ autocrud_gridAndFormDisplayed
com.example.application.AutoCrudTest ‑ autocrud_newUser_userSaved
com.example.application.AutoCrudTest ‑ selectUser_delete
com.example.application.AutoCrudTest ‑ selectUser_editAndDiscard
com.example.application.AutoCrudTest ‑ selectUser_editAndSubmit
com.example.application.AutoCrudTest(production) ‑ autocrud_gridAndFormDisplayed
com.example.application.AutoCrudTest(production) ‑ autocrud_newUser_userSaved
com.example.application.AutoCrudTest(production) ‑ selectUser_delete
com.example.application.AutoCrudTest(production) ‑ selectUser_editAndDiscard
com.example.application.AutoCrudTest(production) ‑ selectUser_editAndSubmit
…

@mcollovati mcollovati merged commit a8be987 into main Mar 22, 2024
10 checks passed
@mcollovati mcollovati deleted the fix/adapt-to-hilla-changes branch March 22, 2024 21:24
@github-actions github-actions bot added the released Issue has been released label Mar 23, 2024
Copy link

This issue has been resolved in 24.0.0-alpha2 (Release Notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format:checked released Issue has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EndpointController.getOpenApiAsResource breaks application
1 participant