Minor updates #36
Closed
Minor updates #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix license Fix license
mcollovati
requested changes
Mar 16, 2020
mcollovati
reviewed
Mar 16, 2020
| public final VertxVaadinService vaadinService() { | ||
| return service; | ||
| @SuppressWarnings("unchecked") | ||
| public final <T extends VertxVaadinService> T vaadinService() { |
There was a problem hiding this comment.
Can you please explain why this final method should be generic?
mcollovati
reviewed
Mar 16, 2020
mcollovati
reviewed
Mar 16, 2020
|
|
||
| private transient Object object; | ||
| public class SerializableHolder implements ClusterSerializable, Serializable { |
There was a problem hiding this comment.
This class was not mean to be used directly by standard serialization, but only within vertx session.
Have you found any problem on having it not Serializable?
mcollovati
reviewed
Mar 16, 2020
|
|
||
| public SerializableHolder() { | ||
| } | ||
| private transient Object object; |
There was a problem hiding this comment.
Can you please move the field declaration above the constructor?
mcollovati
reviewed
Mar 16, 2020
| @@ -28,21 +28,20 @@ | |||
| import java.io.ObjectOutputStream; | |||
| import java.util.function.Consumer; | |||
|
|
|||
| import io.vertx.core.buffer.Buffer; | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
There was a problem hiding this comment.
It seems org.slf4j.LoggerFactory import was accidentally deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor updates to Vaadin 15 codebase