-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename interfaces to ..Interface #1
Comments
I'm all for following standards and a community-level style-guide, even if that means having to adapt my own personal style. However, the PHP-FIG conventions on this feel redundant. I'm not sure how I feel about that, yet. |
No problem, just a suggestion. Should you decide to do it, it's easier to do it now, before it's stable. |
Nope, it feels cleaner to do it this way. I also renamed the RegressionStrategy to something more descriptive while I was at it. |
Thumbs up, the renaming made it clearer. |
Iterate to perfection. :) On Tue, Mar 3, 2015 at 11:16 AM, Revisor notifications@github.com wrote:
Michael Cordingley |
What do you think about following the internal PHP-FIG conventions and naming all interfaces ..Interface?
I would also move the interfaces one level deeper,
LinkingInterface
intomcordingley\Regression\Linking
andRegressionStrategyInterface
intomcordingley\Regression\RegressionStrategy
See https://github.com/php-fig/fig-standards/blob/master/bylaws/002-psr-naming-conventions.md
It would make the code just a little bit more readable.
The text was updated successfully, but these errors were encountered: