Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename interfaces to ..Interface #1

Closed
Revisor opened this issue Mar 2, 2015 · 5 comments
Closed

Rename interfaces to ..Interface #1

Revisor opened this issue Mar 2, 2015 · 5 comments
Assignees

Comments

@Revisor
Copy link

Revisor commented Mar 2, 2015

What do you think about following the internal PHP-FIG conventions and naming all interfaces ..Interface?
I would also move the interfaces one level deeper, LinkingInterface into mcordingley\Regression\Linking and RegressionStrategyInterface into mcordingley\Regression\RegressionStrategy

See https://github.com/php-fig/fig-standards/blob/master/bylaws/002-psr-naming-conventions.md

It would make the code just a little bit more readable.

@mcordingley
Copy link
Owner

I'm all for following standards and a community-level style-guide, even if that means having to adapt my own personal style. However, the PHP-FIG conventions on this feel redundant. I'm not sure how I feel about that, yet.

@mcordingley mcordingley self-assigned this Mar 3, 2015
@Revisor
Copy link
Author

Revisor commented Mar 3, 2015

No problem, just a suggestion.

Should you decide to do it, it's easier to do it now, before it's stable.

mcordingley added a commit that referenced this issue Mar 3, 2015
@mcordingley
Copy link
Owner

Nope, it feels cleaner to do it this way. I also renamed the RegressionStrategy to something more descriptive while I was at it.

@Revisor
Copy link
Author

Revisor commented Mar 3, 2015

Thumbs up, the renaming made it clearer.

@mcordingley
Copy link
Owner

Iterate to perfection. :)

On Tue, Mar 3, 2015 at 11:16 AM, Revisor notifications@github.com wrote:

Thumbs up, the renaming made it clearer.


Reply to this email directly or view it on GitHub
#1 (comment)
.

Michael Cordingley
740.707.7809

mcordingley pushed a commit that referenced this issue May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants