Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

Add tool merge before trying to find board outline #23

Merged
merged 2 commits into from
Jun 10, 2015

Conversation

kasbah
Copy link
Contributor

@kasbah kasbah commented Jun 8, 2015

This good enough? Am I missing something where this could mess things up? Works on the demo board and fixes the MCHCK board as discussed on #20.

@mcous
Copy link
Owner

mcous commented Jun 9, 2015

Cool, I'll take a look at this soon. Sounds good that it works with the demo board and fixes MCHCK.

The only thing I'd be worried about is that some fabs (e.g. OSHPark) recommend putting text on the outline layer to spec cutouts like this. Can you try it out with a board like that and let me know how it goes? I have one here if you don't other Gerbers handy.

@kasbah
Copy link
Contributor Author

kasbah commented Jun 9, 2015

Visually there is no difference between the deployed version and the one with this PR with your reflow board. The cutout isn't cut out in either (and the board outline extends due to the silkscreen). New version: http://kaspar.h1x.com/reflow-top.svg.

@mcous
Copy link
Owner

mcous commented Jun 10, 2015

Cool, as long as it doesn't blow up I'm happy. I'll merge shortly

# undefine (to svae memory I guess?)

# undefine (to save memory I guess?)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 hah thank you for fixing my carelessness

mcous added a commit that referenced this pull request Jun 10, 2015
Add tool merge before trying to find board outline
@mcous mcous merged commit 141dba4 into mcous:master Jun 10, 2015
@mcous
Copy link
Owner

mcous commented Jun 10, 2015

Alright just deployed. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants