Fix: deprecated collections imports #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imports like Sequence, MutableSequence, etc. are deprecated since python3.3 and are removed from 3.8. This commit fixes these import problems for users with 3.8+ ref: python/cpython#81505
For python versions older than 3.3, collections.abc is not implemented. So, a fallback import execption is used to sustain older versions.
|
There seems to be a problem with the 2nd test involving python 3.5. Particularly, with |
|
Didn't realize that there is a updated version of this repo which is being actively maintained for python versions 3.3 and up. PS: This is the new repo link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports like Sequence, MutableSequence, etc. are deprecated since
python 3.3 and are removed from 3.8. This commit fixes these import
problems for users with python 3.8+
ref: python/cpython#81505