forked from cameronneylon/ChemSpiPy
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to new RSC REST API #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer relevant as most endpoints require POST data
Spectra are no longer available from the new API
There is no equivalent to the InChI API CSIDToMol endpoint in the new API.
Only filter_name and get_results implemented so far.
Great to see! I started working on this myself a couple of weeks ago, but I ran out of time half way through. |
Both have been deprecated for long enough.
Instead of get_status and get_results
Closed
This is more consistent with the existing search method
This will hopefully catch DeprecationWarning in Python 2.7
woo! is this ready for use? |
Should be ready, I just need to do a bit more testing and update the documentation, then I will publish version 2.0.0. In the meantime you can clone the repo and |
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details at https://developer.rsc.org
New endpoints
Filter
filter_element
)filter_formula_batch
)filter_formula_batch_results
)filter_formula_batch_status
)filter_formula
)filter_inchi
)filter_inchikey
)filter_intrinsicproperty
)filter_mass_batch
)filter_mass_batch_results
)filter_mass_batch_status
)filter_mass
)filter_name
)filter_results
)filter_results_sdf
)filter_status
)filter_smiles
)Lookups
get_datasources
)Records
get_details_batch
)get_details
)get_external_references
)get_image
)get_mol
)Tools
convert
)validate_inchikey
)Old endpoints
MassSpecAPI
get_datasources
get_details
get_details_batch
get_details_batch
get_mol
simple_search_by_formulasimple_search_by_massSearchAPI
filter_name
filter_name
filter_status
filter_status
filter_results
filter_results
get_details
get_image
filter_name
SpectraAPI
get_all_spectra_infoget_spectrum_infoget_compound_spectra_infoget_spectra_info_listInchiAPI
get_original_mol