Skip to content

Commit

Permalink
Remove test dependencies from binary release artifact
Browse files Browse the repository at this point in the history
This patch removes some test-specific dependencies from the binary
release artifact. These were introduced by the new
flume-shared-kafka-test module that is intended for sharing test code.
Please see the new comment in bin.xml for more information.

Reviewers: Bessenyei Balázs Donát

Closes apache#70

Change-Id: I158eb254ad97fb5b3bd5066cc4e1664d68fb98cf
  • Loading branch information
mpercy authored and Attila Simon committed Feb 20, 2017
1 parent 1f6b929 commit b9a0cd1
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions flume-ng-dist/src/main/assembly/bin.xml
Expand Up @@ -38,6 +38,12 @@
<useProjectArtifact>false</useProjectArtifact>
<excludes>
<exclude>org.apache.flume.flume-ng-clients:flume-ng-log4jappender:jar:jar-with-dependencies</exclude>
<!-- The below test classes get pulled in by flume-shared-kafka-test,
but we don't want them in the final release classpath. Maybe there
is a better way to exclude all of the dependencies of that module;
for now, specifically exclude these test deps. -->
<exclude>junit:junit</exclude>
<exclude>org.hamcrest:hamcrest-core</exclude>
</excludes>
</dependencySet>
<dependencySet>
Expand All @@ -50,8 +56,7 @@
</dependencySet>
</dependencySets>


<fileSets>
<fileSets>
<fileSet>
<directory>../</directory>

Expand Down

0 comments on commit b9a0cd1

Please sign in to comment.