Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insertIfAbsent #2

Merged
merged 1 commit into from
Apr 25, 2016
Merged

Conversation

DreamLinuxer
Copy link
Contributor

Add insertIfAbsent and related tests.

@mcschroeder
Copy link
Owner

I may get a chance to review these changes in detail next week (sorry for not responding sooner), until then, some quick observations: insertIfAbsent makes sense. But I'm skeptical about foldlWithKey, how does that work with concurrent modifications?

@DreamLinuxer
Copy link
Contributor Author

Sorry, I only want to add insertIfAbsent, other commit is irrelevant please ignore them.

@mcschroeder mcschroeder merged commit 62f6878 into mcschroeder:master Apr 25, 2016
@mcschroeder
Copy link
Owner

Looks good; merged. Thank you for your contribution! I will release a new version of the library on Hackage shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants