Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IncrementalStatus into ParserContext #8

Closed
mcserep opened this issue Jul 1, 2018 · 2 comments
Closed

Refactor IncrementalStatus into ParserContext #8

mcserep opened this issue Jul 1, 2018 · 2 comments
Assignees
@intjftw
Labels
Kind: Refactor Refactor required Target: Incremental parsing Towards incremental parsing

Comments

@mcserep
Copy link
Owner

mcserep commented Jul 1, 2018

Currently the file status changes related to incremental parsing are calculated in CppParser. Since this information may be utilized by all plugin parsers, the enum type IncrementalStatus and the std::unordered_map<std::string, IncrementalStatus> map of file status changes defined in CppParser should be refactored into the ParserContext type, thus all plugin parsers will be able to query status changes related to incremental parsing.
@mcserep mcserep added Target: Incremental parsing Towards incremental parsing Kind: Refactor Refactor required labels Jul 1, 2018
@mcserep mcserep mentioned this issue Jul 1, 2018
Closed
@mcserep
Copy link
Owner Author

mcserep commented Jul 4, 2018

As decided on the Ericsson CodeCompass meeting today, the status detection of the files should be refactored into the ParserContext's constructor. Detecting status changes based on the C++ header inclusion information should remain in the CppParser, as this information is specific and should only be used by that parser.

intjftw added a commit that referenced this issue Jul 6, 2018
@intjftw
Solves #8
8f85585
@intjftw
Copy link
Collaborator

intjftw commented Jul 6, 2018

Solved by Queen CPP

@intjftw intjftw closed this as completed Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@intjftw intjftw

Labels
Kind: Refactor Refactor required Target: Incremental parsing Towards incremental parsing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcserep @intjftw