New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreSaveAction does not get called on forms with SPEasyForms configuration #78

Closed
mcsheaj opened this Issue Nov 19, 2018 · 1 comment

Comments

1 participant
@mcsheaj
Owner

mcsheaj commented Nov 19, 2018

In my haste to fix Issue 75 - Form is being submitted without any validation, SP2013 and Later, I broke custom validators. In other words, PreSaveAction does not get called at all.

I've had this issue before, and this time I've fixed it in such a way that I should never have this issue again. I no longer override MS's PreSaveItem method, and I no longer call SPClientForms.ClientFormManager.SubmitClientForm(opt.formId) myself. MS processes the form normally and I modified the onclick handler for the submit button so it calls my own PostValidationAction after all validation and only if some validation failed. Should be much cleaner.

@mcsheaj

This comment has been minimized.

Owner

mcsheaj commented Nov 19, 2018

Fixed in 2018.03

@mcsheaj mcsheaj closed this Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment