boot: SHA512 verification #1967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvlsianpu
reviewed
May 28, 2024
| @@ -82,7 +85,9 @@ typedef psa_hash_operation_t bootutil_sha_context; | |||
| static inline int bootutil_sha_init(bootutil_sha_context *ctx) | |||
| { | |||
| *ctx = psa_hash_operation_init(); | |||
| #if defined(MCUBOOT_SIGN_EC384) | |||
| #if defined(MCUBOOT_SHA512) | |||
| psa_status_t status = psa_hash_setup(ctx, PSA_ALG_SHA_512); | |||
There was a problem hiding this comment.
PSA_ALG_SHA_512, PSA_ALG_SHA_384, PSA_ALG_SHA_258 might be covered under one define.
There was a problem hiding this comment.
512 and 384 are using the same init/clone/update... calls.
256 is handled by different functions.
michalek-no
force-pushed
the
mb-psa-patch
branch
2 times, most recently
from
4153784
to
9de733a
Compare
adds TLV and Kconfig to decouple verification from other options. Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no>
michalek-no
force-pushed
the
mb-psa-patch
branch
from
9de733a
to
2e6d3ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds TLV and Kconfig to decouple verification from other options.