Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more types of image names #119

Merged
merged 12 commits into from
Oct 8, 2020
Merged

Support more types of image names #119

merged 12 commits into from
Oct 8, 2020

Commits on Oct 7, 2020

  1. Support more types of image names 

    Now works with many cases of different image names including ports in registry or containers in folders.

Verified with the following image formats:
host:port/dir/image:tag
host:port/image:tag
host:port/image
host/image:tag
image
image:tag
    @jgough
    jgough committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    97bfea9 View commit details
    Browse the repository at this point in the history

  2. Detect registry correctly from the image name 

    Now the host must contain at least one dot.  Was failing on images of the form dir/image
    @jgough
    jgough committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    b23ffdf View commit details
    Browse the repository at this point in the history

  3. Add tests for buildPullOptions

    @jgough
    jgough committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    4978657 View commit details
    Browse the repository at this point in the history

  4. Add missing import

    @jgough
    jgough committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    006e15e View commit details
    Browse the repository at this point in the history

  5. New repository logic using go-dockerclient

    @jgough
    jgough committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    cba6530 View commit details
    Browse the repository at this point in the history

  6. Updating tests for registry parsing

    @jgough
    jgough committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    626040f View commit details
    Browse the repository at this point in the history

  7. Separating registry parsing into other function

    @jgough
    jgough committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    6a69cd7 View commit details
    Browse the repository at this point in the history

  8. Tests for new registry parsing code

    @jgough
    jgough committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    3969fbf View commit details
    Browse the repository at this point in the history

  9. Merge registry parsing code 

    Separate registry parsing into new function
    @jgough
    jgough committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    4fd2cc6 View commit details
    Browse the repository at this point in the history

  10. Typo string->strings

    @jgough
    jgough committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    b026402 View commit details
    Browse the repository at this point in the history

  11. Removing import no longer needed

    @jgough
    jgough committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    be980b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. improve parseRegistry 

    add a check for `.` or `:` in the first part, if it is there, it must be registry URL
if not this can be image tag
    @taraspos
    taraspos committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    29aaf4c View commit details
    Browse the repository at this point in the history