Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCNTL constants on Windows breaking my test environment #4

Closed
linslin opened this issue Mar 3, 2017 · 4 comments
Closed

PCNTL constants on Windows breaking my test environment #4

linslin opened this issue Mar 3, 2017 · 4 comments

Comments

@linslin
Copy link
Contributor

linslin commented Mar 3, 2017

Hey m8,

you are using PCNTL constants which are not working on Windows. This is breaking my test environment at this moment.

File: PhiremockProccess.php

    /**
     * Stops the process.
     */
    public function stop()
    {
        $this->process->signal(SIGTERM);
        $this->process->stop(3, SIGKILL);
    }
@linslin linslin changed the title PCNTL constants on Windows breaking my test enviromnent PCNTL constants on Windows breaking my test environment Mar 3, 2017
linslin added a commit to linslin/phiremock-codeception-extension that referenced this issue Mar 3, 2017
@linslin
Copy link
Contributor Author

linslin commented Mar 3, 2017

I also fixed an other issue depending on a hardcoded directory separator - 51cb3d0 - Finally your sweet extension is working fine on Windows =)

mcustiel added a commit that referenced this issue Mar 4, 2017
#4 Fixed PCTNL exeption for windows environment
@mcustiel
Copy link
Owner

mcustiel commented Mar 4, 2017

Hey @linslin. Thank you very much for your help with this issue.

@mcustiel
Copy link
Owner

mcustiel commented Mar 4, 2017

Fixed in version 1.2.3

@mcustiel mcustiel closed this as completed Mar 4, 2017
@linslin
Copy link
Contributor Author

linslin commented Mar 4, 2017

@mcustiel glad to help! Thank you so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants