This repository has been archived by the owner on Feb 26, 2018. It is now read-only.
[fix] leaking the last request object after request queue is drained #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
description: this leak can be detected by LeakCanary, see D/LeakCanary﹕ In io.github.pandacast:1.1:2. D/LeakCanary﹕ * io.github.pandacast.MainActivity has leaked: D/LeakCanary﹕ * GC ROOT thread com.android.volley.NetworkDispatcher.<Java Local> (named 'Thread-5690') D/LeakCanary﹕ * references io.github.pandacast.model.RestClient$LiveListRequest.mListener D/LeakCanary﹕ * references io.github.pandacast.LiveListFragment$LiveListAdapter.mContext D/LeakCanary﹕ * leaks io.github.pandacast.MainActivity instance root cause: In NetworkDispatcher.run(), the local variable `request` hold the last Request object. If there is no more Request object in `mQueue`, `request = mQueue.take();` in line 90 would **block** until new Request object enqueue, which cause the leak of last Request object. In common pracice, Request has strong reference to Listener and Listener is either implmented by Activity or referenced by Activity as instance of inner class which implement Listener. Thus cause leaking the whole Activity instance. how to fix: set request to **null** before `request = mQueue.take();`
|
lgtm |
mcxiaoke
added a commit
that referenced
this pull request
Jun 26, 2015
[fix] leaking the last request object after request queue is drained
|
great! |
|
released at v1.0.17 |
This was referenced Aug 7, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description:
this leak can be detected by LeakCanary, see
root cause:
In
NetworkDispatcher.run(), the local variablerequestholdthe last Request object. If there is no more Request object in
mQueue,request = mQueue.take();in line 90 would blockuntil new Request object enqueue, which cause the leak of last
Request object.
In common practice, Request has strong reference to Listener and
Listener is either implemented by Activity or referenced by
Activity as instance of inner class which implement Listener.
Thus cause leaking the whole Activity instance.
how to fix:
set request to null before
request = mQueue.take();