add checking of return status on fstat calls

[ncroxon]

There are a few places we don't check the return status when calling fstat for success. Clean up the calls by adding a check before continuing.

V2: clean up warnings/errors from checkpatch.pl

[mtkaczyk]

Hey @ncroxon,
There is one small issue. Please fix it and we are ready to go :)

[mtkaczyk]

You don't need braces in this case, there is one instruction inside if but it is not an issue, just FYI,

[mtkaczyk]

Oh, bracases here totally change the flow.

Previously, only printf() was executed verbose >=0. Now, the fsttat is executed. I think that it should be:

Suggested change

	if (c->verbose >= 0) {
	if (c->verbose >= 0)
	printf("%s saved as %s.\n", dev, fname);
	close(fl);
	ret = fstat(fd, &dstb);
	close(fd);
	if (ret) {
	unlink(fname);
	free(fname);
	return 1;
	}

[ncroxon]

I pushed a new version (V3) to the branch.

[mtkaczyk]

[PATCH V3] add checking of return status on fstat calls
There are a few places we don't check the return status when
calling fstat for success. Clean up the calls by adding a
check before continuing.

V3: fix Dump.c braces to execute verbose properly.
    clean up braces with only one instruction inside.
V2: clean up warnings/errors from checkpatch.pl

Signed-off-by: Nigel Croxon <ncroxon@redhat.com>

I will cherry-pick this commit so please remove [PATCH V3] from title and v2 and v3 changes from description.
We have to use comment to note changes from now.. thanks!