Redirect list convert into a view, exposed filters added. #28
Conversation
| @@ -8,7 +8,7 @@ | |||
| /** | |||
| * Implements hook_views_data(). | |||
| */ | |||
| function redirect_views_data() { | |||
| function redirect_testing_views_data() { | |||
There was a problem hiding this comment.
This needs to be removed now. (the whole function)
|
Needs to merged with 8.x-1.x. There is a new created column now that needs to be added to the view and it will conflict on the removed list builder. |
|
tests are not working because a patch about LanguageFormatter is needed, https://www.drupal.org/node/2461013. |
…also removed the hook of the views
…iews.view.redirect.yml
…de filter in the view
giancarlosotelo
force-pushed
the
convertlist
branch
from
5e95116
to
8bd8adf
Compare
|
This looks pretty good! from/to filter doesn't seem to be working, though, might need some custom views plugins. Also ,in the table settings, we should allow sorting for all columns where it makes sense and sort by created desc by default. |
|
I was adding a custom view plugin but I realized that changing the operator in the filter criteria was enough. I added a test also for both fields. |
|
Indeed, this works well well now. Just some cleanup and we're done. Drop redirect.views.inc completely and drop the remaining custom views plugins, we no longer need those. |
|
Very nice, merged! |
Added the view and also added a formatter to Redirect Source item.