Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a composer.json #34

Closed
wants to merge 1 commit into from
Closed

Add a composer.json #34

wants to merge 1 commit into from

Conversation

mscharley
Copy link

Simply adds a basic composer.json to identify the project in lieu of using Drupal.org and Drupal Packagist. Allows people to use the port here with Composer-based sites till the port makes it back onto Drupal.org.

@Berdir
Copy link
Member

Berdir commented Dec 7, 2015

Happy to merge the composer change, but not sure why we need the .gitignore here? dependencies wouldn't be added here anyway?

@Berdir
Copy link
Member

Berdir commented Dec 7, 2015

Note: I've just moved this back to d.o, please provide this as a patch there.

@Berdir Berdir closed this Dec 7, 2015
@mscharley
Copy link
Author

I'm happy to provide a patch on d.o as well if you're still interested, though for me it's irrelevant now. d.o builds composer packages for downstream users for every package release on d.o whether they supply a composer.json file or not. Let me know if you want me to provide the patch anyway.

With regards to the gitignore, dependencies should be added to the composer.json as well, otherwise it rather defeats the point of having it. Ultimate Cron 2.x just doesn't have any right now. If you're interested in seeing Composer in action in D8 then checkout https://www.drupal.org/sandbox/mscharley/2629336 and especially https://github.com/mscharley/drupal-heroku-demo which is the demo application for that project.

@Berdir
Copy link
Member

Berdir commented Dec 24, 2015

Yes, dependencies should be added. but those dependencies would not be added to the module folder, they would be added to the top-level vendor folder, that's how composer/class-loading works. Both for the composer manager approach and for the full composer based approach.

Anyway, this moved to d.o now. You're welcome to provide a patch there if you want to, closing this.

@Berdir Berdir reopened this Dec 24, 2015
@Berdir Berdir closed this Dec 24, 2015
@naveenvalecha
Copy link

but those dependencies would not be added to the module folder,

Right! For more detailed information blog link attached https://bojanz.wordpress.com/2015/09/18/d8-composer-definitive-intro/

Anyhow I have filed an issue in d.o. issue queue https://www.drupal.org/node/2640244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants