Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #8

Merged
merged 1 commit into from
Feb 18, 2021
Merged

minor fixes #8

merged 1 commit into from
Feb 18, 2021

Conversation

Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented Feb 17, 2021

https://dart-lang.github.io/linter/lints/sort_constructors_first.html

the constructor should come first.
we should use const whenever possible.

@Abhishek01039
Copy link
Contributor Author

hello @md-weber
can you please review this PR?
Thanks

@md-weber
Copy link
Owner

Thank you for helping out. I guess it would be best if we add a listing package in the future to handle such problems.
Regarding this PR it looks LGTM thank you 💯

@md-weber md-weber merged commit bd59f8d into md-weber:master Feb 18, 2021
@md-weber md-weber added the enhancement New feature or request label Feb 18, 2021
@md-weber md-weber linked an issue Feb 18, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add linting rules to the package
2 participants