Packet queues implementation #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A little code added
Update the code for Async Queue attribute.
Mastering asyncio and getting familiar with asynchronous code. Seems like I am getting closer to TimestampedQueue implementation.
Seems like FIFO Queue is ready. Queues API was updated a bit.
1) TimeStamp variable removed datetime and perf_coutner used instead 2) TimestampedPacketsQueue uses perf_counter instead of datetimte (it is more accurate) 3) algorithm for TimestampedPacketsQueue defined
Timestamped queue is created. The performance has to be improved, but I suppose selecting a probper loop would make the trick.
Fix issues found by Static Code Analysis.
Get rid of performance checking for async code.
Closed
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 1893 1952 +59
=========================================
+ Hits 1893 1952 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Remove code that counted unfinished tasks for the second time (duplicate to iunternal Queue implementation).
mdabrowski1990
commented
Dec 28, 2021
tests/software_tests/transport_interface/test_abstract_packet_queue.py
Outdated
Show resolved
Hide resolved
tests/software_tests/transport_interface/test_abstract_packet_queue.py
Outdated
Show resolved
Hide resolved
tests/software_tests/transport_interface/test_abstract_packet_queue.py
Outdated
Show resolved
Hide resolved
Fix remarks found during self-review.
for consistency
Update workflow to exclude performance tests in unit testing.
typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation for (FIFO and timed one) queues are added.
How Has This Been Tested?
Unit tests and integration tests.
Process
I know the process and did my best to follow it