Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample code error: Checkmark misvalidation on blur #170

Closed
avimar opened this issue May 25, 2020 · 2 comments
Closed

Sample code error: Checkmark misvalidation on blur #170

avimar opened this issue May 25, 2020 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed released

Comments

@avimar
Copy link

avimar commented May 25, 2020

Describe the bug

The sample code from https://github.com/mdauner/sveltejs-forms#how-to-use produces an issue with onblur.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://svelte.dev/repl/b8a2d021a1484700856a17012b3c0602?version=3.22.3
  2. Click 2x operating systems.
  3. Uncheck 1x operating system.
  4. Click "submit"

Expected behavior
At step 2, upon clicking a second operating system, the error should have gone away.
At step 3, upon unchecking 1x OS, the error should remain.

Screenshots
22 seconds in on https://www.awesomescreenshot.com/video/141161

Desktop (please complete the following information):

  • OS: win10
  • Browser chrome
  • Version 83.0.4103.61 (Official Build) (64-bit)
@mdauner mdauner added bug Something isn't working help wanted Extra attention is needed labels May 28, 2020
oncode pushed a commit to oncode/sveltejs-forms that referenced this issue Jun 24, 2020
fix(choice): validate on store change and not on change event (closes m…
f1e4d95 
…dauner#170)
@oncode oncode mentioned this issue Jun 24, 2020
Merged
@mdauner mdauner closed this as completed in cf40ed3 Sep 1, 2020
mdauner pushed a commit that referenced this issue Sep 1, 2020
@oncode @mdauner
fix(choice): validate on store change (closes #170)
98fe7fa 
Co-authored-by: Manuel Sommerhalder <hello@oncode.ch>
@mdauner
Copy link
Owner

mdauner commented Sep 1, 2020

🎉 This issue has been resolved in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@avimar
Copy link
Author

avimar commented Sep 1, 2020

Confirmed fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avimar @mdauner