-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add setColor(string)
method
#91
Comments
When you say an instance, do you mean a specific input field or a group of fields that use the same Coloris instance? |
Its the specific input I am trying to set the color for or "instance"
|
Here is what I really do so it works for popup mode or inline mode. /**
* Sets the current color
* @param {string} color the color to set
*/
setColor: function(color) {
if (!color) {
return;
}
var newColor = color.toLowerCase();
var input = this.popup ? this.input : this.jq.find('#clr-color-value');
Coloris.setColor(newColor, input[0]);
}, |
I think a better and more efficient way is to just set the value of the target fields directly and then trigger an function setColor(color, target) {
const colorValue = document.querySelector('#clr-color-value');
// Color fields listen for an "input" events while the color value field
// within the picker listens for a "change" event
const event = target === colorValue ? 'change' : 'input';
target.value = color;
target.dispatchEvent(new Event(event, { bubbles: true }));
} |
Or even better, here is a rewrite of your code above: /**
* Sets the current color
* @param {string} color the color to set
*/
setColor: function(color) {
if (!color) {
return;
}
var newColor = color.toLowerCase();
var input = this.popup ? this.input : this.jq.find('#clr-color-value');
var event = this.popup ? 'input' : 'change';
var target = input[0];
target.value = color;
target.dispatchEvent(new Event(event, { bubbles: true }));
}, |
This is pretty close. The only difference is with mine because our wrapper send AJAX events on change of color I need the change event fired for either popup or inline and your This was vital for us so the change event fires for inline or popup and ONLY fires if the color actually changes. if (oldColor !== color) {
currentEl.dispatchEvent(new Event('change', { bubbles: true }));
} |
How about this: /**
* Sets the current color
* @param {string} color the color to set
*/
setColor: function(color) {
if (!color) {
return;
}
var newColor = color.toLowerCase();
var input = this.popup ? this.input : this.jq.find('#clr-color-value');
var target = input[0];
var oldColor = target.value.toLowerCase();
var triggerInputEvent = !!this.popup;
if (color.toLowerCase() !== oldColor) {
target.value = color;
triggerInputEvent && target.dispatchEvent(new Event('input', { bubbles: true }));
target.dispatchEvent(new Event('change', { bubbles: true }));
}
}, |
This seems to work! |
Should I close this then? |
Add a first class method to set the color of an instance similar to..
The text was updated successfully, but these errors were encountered: