Update quickstart npm docs to warn for monorepo pitfall #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Mayer <frank@frankmayer.net>
|
Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@frankmayer). In order for your PR to be reviewed and merged, please sign our CLA first. If there are any questions, please don't hesitate to get in touch with our team. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Hi! Thank you for your PR. I think it will be better if we add a new section with installation guide for bun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update quickstart npm docs to warn users of a potential monorepo pitfall.
In my case I was testing Bun in parallel to my main pnpm/turborepo environment, and tw-elements was not working when packages were installed with bun.
It turned out, bun was only installing it into the root node_modules and not also providing a symlink to the actual app's node_modules. As no error messages were logged, it took some time to find the culprit, so I wanted to spare other users the pain :)