Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Level Item Clickable Option #8

Closed
wants to merge 2 commits into from
Closed

Top Level Item Clickable Option #8

wants to merge 2 commits into from

Conversation

patrickocoffeyo
Copy link

Added an option (defaults to true) that allows users to make top level navigation items clickable. Updated readme documentation with new param.

Patrick Coffey added 2 commits March 8, 2013 10:08
Adds an option (with a default) that allows you to make the parent item clickable.
@CWSpear
Copy link
Collaborator

CWSpear commented Mar 8, 2013

What exactly does this do? If you add the data-toggle="dropdown" attribute to the right place, it allows you to click the nav item to open it. It seems that your changes are necessary?

Unless... I discovered a typo in the demo packaged with the repo that prevented bootstrap.js from being pulled in, so when you viewed the demo at the tablet or mobile breakpoint, the nav didn't work.

I fixed it in the demo. Does that take care of your issue? If not, could you explain the "why" behind your changes?

@patrickocoffeyo
Copy link
Author

@CWSpear, if you don't add the class disabled to the item that has the data-toggle="dropdown", it doesn't allow that item to be clickable, at least that's what I was experiencing: twbs/bootstrap#983 (See comment 4)

Maybe there is a problem with the way I am implementing the script though?

@CWSpear
Copy link
Collaborator

CWSpear commented Mar 11, 2013

I did find a couple quirks, but nothing like what you described. I'll look into it further.

@patrickocoffeyo
Copy link
Author

Interesting... I'll look into it further as well. Thanks!

@CWSpear
Copy link
Collaborator

CWSpear commented Apr 4, 2013

Closing this as I think it's a non-issue and has been 3 weeks since there was any activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants